This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Fix/Okta array in customData issue#609
Open
skhvan1111 wants to merge 2 commits intostormpath:oktafrom
Open
Conversation
skhvan1111
changed the title
Member
|
Hi @skhvan1111 , thanks for the PR! We need to support deep objects as well, so this has to recurse downward. Today I was fixing some other issues with custom data, and I have addressed the array issue described here. Can you please try this commit on the head of the okta branch and let me know if it fixes your issues: Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows user to save arrays or any other objects as account customData.
When i tried to save array ["a", "b","c"] as customData.values
dot.dot produced
"values.0": "a",
"values.1": "b",
"values.2": "c"
As its not valid fields set for okta, it raises 400 error with related message.